Skip to content
This repository has been archived by the owner on May 7, 2018. It is now read-only.

Everything builds in one run! (or at least should) #7

Closed
wants to merge 1 commit into from
Closed

Everything builds in one run! (or at least should) #7

wants to merge 1 commit into from

Conversation

PawelLyskawinski
Copy link

I've added libnpa as a submodule for this project, since it has some dependancy issues if there isn't a folder named "libnpa" one directory higher then libnpengine.

  • Change in .gitmodules will probably have to be changed to proper repo instread of my fork (which is modified as well for the sake of nice one command builds.
  • Boost timers didn't compile out of box so I switched them with STL eqivalents. I'm not sure if they work how intended though.

@@ -0,0 +1,3 @@
[submodule "externals/libnpa"]
path = externals/libnpa
url = http://github.com/PawelLyskawinski/libnpa.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PawelLyskawinski
This cannot be right

EDIT: nevermind, didn't read your message, sorry!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess I rushed a little bit. This should be http://github.com/FGRE/libnpa.git now. I'll change this and renew pull request later on then.

@krofna
Copy link
Member

krofna commented Jan 14, 2014

I used boost to maintain compatibility with win32 cross compiler, but since gstreamer broke cross compilation I'm gonna accept this as well.

@PawelLyskawinski
Copy link
Author

I build it on linux, so there aren't that much major problems with c++11, but I imagine that visual studios might choke on stuff like chrono (and maybe even mingw builds? I'll compile this with mingw and report results).
I had some problems with finding boost::this_thread::sleep_for (this might be a problem of my boost installation though). If I remember correctly SFML has its own timers. I'll play a little more with it and give a pull request next time then :)

@krofna
Copy link
Member

krofna commented Jan 14, 2014

I pulled this to my local repo and it didn't compile. Broken CMakeLists?

/home/krofna/Hacking/libnpengine/include/resourcemgr.hpp:21:27: fatal error: npaiterator.hpp: No such file or directory

@PawelLyskawinski
Copy link
Author

Ah right, I forgot to mention.
before compiling you would probably need to run those commands in main libnpengine folder:
git submodule init
git submodule update
This will download externals (in our case libnpa)

@krofna
Copy link
Member

krofna commented Jan 14, 2014

Make sure to document that in README

@krofna krofna mentioned this pull request Jan 19, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants