Update GitHub workflow to fix the broken build#510
Merged
lyrixx merged 3 commits intoFGRibreau:masterfrom Jan 31, 2025
YasharF:master
Merged
Update GitHub workflow to fix the broken build#510lyrixx merged 3 commits intoFGRibreau:masterfrom YasharF:master
lyrixx merged 3 commits intoFGRibreau:masterfrom
YasharF:master
Conversation
Contributor
Author
|
Not sure why this pull request didn't trigger a build, but I already tested it in my fork in this github action run: https://github.com/YasharF/mailchecker/actions/runs/12817070395 |
Contributor
Author
|
Test run of this workflow https://github.com/YasharF/mailchecker/actions/runs/13033640026/workflow |
lyrixx
reviewed
Jan 29, 2025
Collaborator
lyrixx
left a comment
There was a problem hiding this comment.
Thank you very much for this PR.
I have a little question, otherwise it's perfect
Contributor
Author
|
Update: removed the matrix run, and set the workflow to run with nodejs 22.x. Here is a test run of the workflow |
lyrixx
approved these changes
Jan 31, 2025
Collaborator
lyrixx
left a comment
There was a problem hiding this comment.
Thanks a lot for your first, and very valuable contribution 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the workflow to run with the current LTS versions of Node.js. The list in the matrix will need to be updated as the LTS versions change. April 2025 is probably a good time to revisit this list as node 18 will enter EoL and they are supposed to start releasing Node 24.Updated the workflow to latest LTS versions of Node.js aka 22.x.