Fix/macos on main#2
Open
Nifalu wants to merge 6 commits into
Open
Conversation
The codebase/ + frontends/ refactor landed before the macOS fixes from unified-ui, breaking macOS on main. Bring them into the new layout: - main.py: defer tray/notifications to after exec() (crash on Finder launch) - tray.py: programmatic template icons for macOS menu bar - auth.py: respect pre-set PLAYWRIGHT_BROWSERS_PATH (bundled browsers) - vpn_daemon.py: drop dead protocol-import block - build-macos.sh: cp the daemon instead of an embedded, drifted heredoc
Installer's bundle-relocation feature can redirect the install into any other copy of the bundle LaunchServices finds on disk (e.g. a stale dev build). Pin the install path via a component plist with BundleIsRelocatable=false.
The build script installs Chromium into Contents/Resources/browsers/ but nothing set PLAYWRIGHT_BROWSERS_PATH at runtime, so Playwright fell back to ~/.cache/ms-playwright and tried to download a fresh browser — failing on fresh Macs. Detect the PyInstaller bundle in __main__ and wire the env var before vpn_ui imports run.
Contributor
Author
|
@blacksheeep kannst du testen ob auf linux noch alles so läuft wie es sollte? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix macOS: main has been crashing on connect since the refactor
Main's codebase/ + frontends/ reorg landed before 5 macOS fix commits from unified-ui were ported. This PR brings them forward into the new layout and fixes three concrete bugs that went with the refactor.
Changes:
frontends/osx/build.sh — open the built pkg at the end.