Bugfix: Allow DeviceAgentVector_impl to be copy constructed.#1291
Draft
Robadob wants to merge 1 commit into
Draft
Bugfix: Allow DeviceAgentVector_impl to be copy constructed.#1291Robadob wants to merge 1 commit into
Robadob wants to merge 1 commit into
Conversation
Tests pass, but requires some discussion before adding this. The 'bug' is unintended behaviour, which may increase memory transfers etc. Closes #1290
Robadob
force-pushed
the
bugfix_davimpl_copy
branch
from
5c752a8 to
4bccb93
Compare
Member
|
Todo:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests pass, but requires some discussion before adding this. The 'bug' is unintended behaviour, which may increase memory transfers etc.
Haven't updated test suite yet, bc not sure we actually want to fix this in this manner.
Closes #1290