FACT: Comment out the 0ms fade handler. #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@DanielJonesEB does this FAudio dylib fix the issue? https://github.com/FNA-XNA/FAudio/actions/runs/12393993213/artifacts/2337691633 |
|
Hey @flibitijibibo! I'm just getting back up to speed after the Christmas. Is there a compiled build I can download to test it, or should I attempt to build from source? |
There's a 1-frame timing issue where two sounds in the same category being played consecutively should still have both sounds _technically_ playing, even if the fade time is 0ms. See #368 for details.
flibitijibibo
force-pushed
the
0fadetiming
branch
from
89d2e29 to
4814d39
Compare
Member
Author
|
Rebased this patch just now, an SDL2 osx dylib should show up toward the bottom of this page: https://github.com/FNA-XNA/FAudio/actions/runs/12636518921 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a 1-frame timing issue where two sounds in the same category being played consecutively should still have both sounds technically playing, even if the fade time is 0ms.
Should fix #368.