win32: Use AUTOCONVERTPCM when initializing the audio client. #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, on Wine, IsFormatSupported() advertises every (extensible) format as supported, and correspondingly Initialize() accepts every (extensible) format. However that behavior is not what happen on Windows, where both IsFormatSupported() and Initialize() rejects format the differ from the current mmdevapi mix format for anything other than the sample format. This might be rectified at some point in Wine. To maintain the current behavior in FAudio, we stop querying with IsFormatSupported() and pass flag AUTOCONVERTPCM to Initialize().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't manage to compile FAudio with the win32 backend. I tested this patch with a few games by cherry picking it in Proton and everything seemed to work just as before.
See the commit message for some explanation. Currently Wine has the same behavior independently of whether
AUTOCONVERTPCMis set, but on Windows callingInitialize()withoutAUTOCONVERTPCMwill be rejected unless the requested format is similar enough to the mix format. I plan to submit a MR that aligns Wine with Windows, so if you want to preserve the current behavior for FAudio flagAUTOCONVERTPCMshould be passed instead.