Skip to content

Patches from Zeb #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flibitijibibo merged 52 commits into from
Jan 1, 2026
Merged

Patches from Zeb #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
cbc9439
FACT: Queue wavebanks instead of complete PREPARED notifications.
Aug 13, 2025
8f2399c
FACT: Queue prepared wavebanks regardless of notification flags.
Aug 13, 2025
7f9e965
FACT: Factor out a send_wavebank_notification() helper.
Aug 13, 2025
802e606
FACT: Factor out a send_wave_notification() helper.
Aug 13, 2025
e072f5d
FACT: Separate a send_soundbank_notification() helper.
Aug 13, 2025
99b6f63
FACT: Store a list of registered notifications.
Aug 13, 2025
6e00774
FACT: Define and use an symbolic FAUDIO_OK return value.
Aug 14, 2025
c030831
FACT: Return FACTENGINE_E_INVALIDUSAGE from FACTCue_Play() if playing…
Aug 19, 2025
a8210e2
FACT: Return FACTENGINE_E_INVALIDUSAGE from FACTWave_Play() if stopped.
Aug 25, 2025
3d962cd
FACT: Validate the source count in SetMatrixCoefficients().
Aug 19, 2025
f26f585
FACT: Return the device OutputFormat from GetFinalMixFormat().
Aug 20, 2025
5004c7f
FACT: Validate the destination count in SetMatrixCoefficients().
Aug 20, 2025
8b8a976
FACT: Return FACTENGINE_E_INVALIDUSAGE when the STREAMING flag does n…
Aug 25, 2025
15e2396
FACT: Remove an incorrect comment.
Aug 25, 2025
82632a8
FACT: Clear FACT_STATE_PREPARED in FACTWave_Play().
Aug 25, 2025
cd65f74
FACT: Ignore FACTWave_Play() when paused.
Aug 25, 2025
dbcbda4
FACT: Do not clear PAUSED in FACTCue_Play().
Aug 25, 2025
1c69e53
FACT: Use const pointers for parsing.
Aug 26, 2025
f18cf06
FACT: Use an emumeration for the fade type.
Aug 27, 2025
5d15e70
FACT: Make some functions static.
Aug 28, 2025
ebea472
FACT: Remove some redundant zero initialization.
Aug 28, 2025
17ce375
FACT: Use a proper structure for RPC codes.
Aug 28, 2025
e8dc19b
FACT: Use a convenience FACTEvent pointer in FACT_INTERNAL_ParseTrack…
Aug 28, 2025
464cff2
FACT: Use const FACTEvent pointers where possible.
Aug 28, 2025
04d63c2
FACT: Use a convenience FACTTrack pointer in FACT_INTERNAL_ParseSound…
Aug 28, 2025
5255bb2
FACT: Use const FACTTrack pointers where possible.
Aug 28, 2025
080974b
FACT: Use a convenience FACTSound pointer in FACT_INTERNAL_ParseSound…
Aug 28, 2025
e5b85f9
FACT: Use const FACTSound pointers where possible.
Aug 28, 2025
7c9ba23
FACT: Use a convenience FACTVariationTable pointer in FACT_INTERNAL_P…
Sep 2, 2025
1a3c068
FACT: Put the variation table code in the FACTVariationTable struct.
Sep 2, 2025
1065220
FACT: Correctly set numVariations for single-sound cues.
Sep 2, 2025
8fe2879
FACT: Correctly set iaVariableIndex for non-interactive cues.
Sep 2, 2025
f7687fa
FACT: Separate a get_active_variation_index() helper.
Sep 8, 2025
f8827dc
FACT: Store the variation index in the sound instance.
Sep 8, 2025
02d77e6
FACT: Use the variation index in FACTCue_GetProperties().
Sep 8, 2025
03ed419
FACT: Set the weight to 0xff for interactive variations.
Sep 8, 2025
9d2343d
FACT: Rename "fadeType" to "state".
Sep 8, 2025
ca28ac7
FACT: Factor out a handle_instance_limit() function.
Sep 8, 2025
2dcca17
FACT: Create an FACTSoundInstance immediately if possible.
Sep 11, 2025
1736719
FACT: Use a convenience FACTTrackInstance pointer in create_sound().
Sep 12, 2025
81abf19
FACT: Initialize activeWave immediately.
Sep 12, 2025
8492655
FACT: Store non-interactive weights as uint8_t.
Sep 11, 2025
41d70ec
FACT: Don't check for failure from FACTWave_GetProperties().
Sep 11, 2025
99afd9a
FACT: Fix wave duration calculation in FACTCue_GetProperties().
Sep 12, 2025
d23e99a
FACT: Rename "track" fields of FACTEvent.
Sep 12, 2025
616be1f
FACT: Initialize the ORDERED variation count to -1.
Sep 12, 2025
eec9551
FACT: Properly fill the track variation count and index in GetPropert…
Sep 12, 2025
d8cb29d
FACT: Multiply the duration by the loop count.
Sep 12, 2025
929958f
FACT: Record and report the background music flag for waves.
Sep 12, 2025
d7007c8
win32: Propagate failure in FAudio_PlatformGetDeviceDetails().
Nov 20, 2025
c7851d5
FACT: Do not set FACT_STATE_PREPARED for sound banks.
Nov 21, 2025
3060e44
utils: Buildfixes for FACT internal changes
flibitijibibo Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/FACT.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ extern "C" {
#endif /* __cplusplus */

#define FACTENGINE_E_NONOTIFICATIONCALLBACK 0x8ac70004
#define FACTENGINE_E_INVALIDUSAGE 0x8ac70006
#define FACTENGINE_E_INVALIDDATA 0x8ac70007
#define FACTENGINE_E_INSTANCELIMITFAILTOPLAY 0x8ac70008
#define FACTENGINE_E_INVALIDVARIABLEINDEX 0x8ac7000a
Expand Down
2 changes: 2 additions & 0 deletions include/FAudio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,8 @@ typedef struct FAudioXMA2WaveFormatEx

/* Constants */

#define FAUDIO_OK 0x0
#define FAUDIO_E_FAIL 0x80004005
#define FAUDIO_E_OUT_OF_MEMORY 0x8007000e
#define FAUDIO_E_INVALID_ARG 0x80070057
#define FAUDIO_E_UNSUPPORTED_FORMAT 0x88890008
Expand Down
Loading
Loading