Skip to content

added copyrights to the signin page #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

added copyrights to the signin page #276

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
256f271
added copyrights to the signin page
aryabyte21 Apr 14, 2022
6fdb4ff
Changes the color of copyright text to white
aryabyte21 Apr 14, 2022
0a1ec43
fixed the issues pointed out
aryabyte21 Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/components/SignIn/SignIn.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,17 @@ export class SignIn extends Component {
<Link to="/quickstart" href="/quickstart">
Signup
</Link>
<div className="footer-copyright" style={{color:"white"}}>
Copy link
Collaborator

@jennydaman jennydaman Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the CSS class footer-copyright here is a bad practice, while it's true that CSS classes are global, we would like to have some notion of scope. I would suggest either moving the class out of src/components/Footer/Footer.css and to some other CSS file which is explicitly designated to contain global classes, or copy the class to SignIn.css

Copy link
Collaborator

@jennydaman jennydaman Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoping would protect against a fix for #151 (which enforces scoping)

Copy link
Author

@aryabyte21 aryabyte21 Apr 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @jennydaman I have copied the class to SignIn.css

© 2018 - {new Date().getFullYear()} Boston Children&apos;s Hospital, Red
Hat, Massachusetts Open Cloud, Boston University. All rights reserved.
</div>
</p>

</Form>

</CardBody>
</Card>

</div>
</div>
);
Expand Down