Skip to content

Conversation

@lmcapacho
Copy link
Contributor

This pull request improves the interaction between the text fields and the I/O ports table by introducing update flags to prevent infinite loops caused by mutual onChange triggers.

  • Add support for reading individual form field values by index.
  • Encapsulated updateIOPortsTable and onEnterIOPortsTable inside FormBasicCode.
  • Replaced self.table with explicit table parameter to clarify ownership.
  • Added _updatingFromText and _updatingFromGrid flags to avoid recursive updates.
  • Updated onChange callbacks in the constructor to respect the flags.

This ensures a more stable and maintainable synchronization logic between user inputs and the I/O ports configuration table.

@cavearr
Copy link
Member

cavearr commented Jul 12, 2025

Thanks @lmcapacho , i'm reviewing now! thanks again!

@cavearr cavearr merged commit bdd69b7 into FPGAwars:develop Jul 12, 2025
1 check passed
@jojo535275
Copy link
Contributor

Gracias Luis Miguel for you work on this update,
i will give it a try once the executables are ready!

@cavearr
Copy link
Member

cavearr commented Jul 12, 2025

in few minutes will be ready! i've talked with @lmcapacho few days ago, if you do more changes out of this feature, wait some days, i'm rewritting a lot of thinks and the merge will be very complicated. at the end of july aprox i'll have the first new verion approach.

Good weekend!

@cavearr
Copy link
Member

cavearr commented Jul 12, 2025

the building process is broken by nwjs update, i'm working on it, i'm telling you soon.

@jojo535275
Copy link
Contributor

ok, thanks Carlos,
Have a nice weekend too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants