Skip to content

Conversation

@JYoung413
Copy link
Contributor

All changes we made during the 2018 Palmetto regional.

JYoung413 and others added 30 commits January 10, 2018 19:26
…stead of indivisual setting, also implemented actual methods...
…abberPositionButton because it wasnt working, will fix later.
autoSelector.addDefault("Switch Only", Autos.SwitchOnly);
autoSelector.addObject("Scale To Switch", Autos.ScaleToSwitch);
autoSelector.addObject("Two Scale", Autos.TwoScale);
autoSelector.addObject("Do Nothing", Autos.DoNothing);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put a new line here.

oi = new OI();
drivetrain.timer.start();
sideSelector = new SendableChooser();
autoSelector = new SendableChooser();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line break here too.


String gameDataTemp = DriverStation.getInstance().getGameSpecificMessage();
if (gameDataTemp != null) {
gameData = DriverStation.getInstance().getGameSpecificMessage().substring(0, 2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just do gameDataTemp.substring. DRY

}
} else {
//Auto code for right side
switch (gameData) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Own function + test.

Robot.cubeLift.punch();
}

protected void execute() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRUNE

Command scoreCubeAgain = new ScoreCmdGrp();

public LeftSideCloseScaleCloseSwitchAuto() {
/*addSequential(intakeDown);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOOOOOOOOOOOOOOO


public RightSideCloseScaleFarSwitchAuto() {
/*
addSequential(intakeDown);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHAME

private volatile LiftState state = LiftState.Stationary;

private volatile TalonSRX rightElevatorLeader = new TalonSRX(RobotMap.RIGHT_ELEVATOR_MAIN);
private VictorSPX rightElevatorSlave = new VictorSPX(RobotMap.RIGHT_ELEVATOR_SLAVE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare stuff as IMotorController

}
checkIfToppedOut();
checkIfZeroedOut();
SmartDashboard.putNumber("i counter", i);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

double currentVal = 0;
switch (newPorts) {
case Drivetrain:
currentVal = (pdp.getCurrent(0) + pdp.getCurrent(1) + pdp.getCurrent(2) + pdp.getCurrent(3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the magic numbers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants