Keep the original NHE associated with a re around #18751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donaldsharp
commented
May 2, 2025
donaldsharp
commented
- Keep the original NHE associated with a re around.
- Write a test that shows that it works
donaldsharp
force-pushed
the
keep_original_nhe
branch
from
f27c9c5 to
11bfc0e
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
donaldsharp
force-pushed
the
keep_original_nhe
branch
from
11bfc0e to
afc17a2
Compare
donaldsharp
force-pushed
the
keep_original_nhe
branch
from
afc17a2 to
2b70f8e
Compare
For test bgp_redistribute_table there is a function that removes unwanted json attributes. Let's add receivedNexthopGroupId to that list. Signed-off-by: Donald Sharp <[email protected]>
Upper level protocols are sending down a list of nexthops that a temporary nhg was created to hold it. After route resolution is done, this NHG is thrown away. Let's keep this received NHG as a pointer off the RE. Follow the `installedNexthopGroupId` pattern for display purposes at this point in time. Signed-off-by: Donald Sharp <[email protected]>
Add a simple test that does some basic exercising of the receivedNHGId and that it worked as expected. Signed-off-by: Donald Sharp <[email protected]>
donaldsharp
force-pushed
the
keep_original_nhe
branch
from
2b70f8e to
9524330
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.