Skip to content

Keep the original NHE associated with a re around #18751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025

Conversation

donaldsharp
Copy link
Member

  1. Keep the original NHE associated with a re around.
  2. Write a test that shows that it works

@frrbot frrbot bot added tests Topotests, make check, etc zebra labels May 2, 2025
@donaldsharp donaldsharp force-pushed the keep_original_nhe branch from f27c9c5 to 11bfc0e Compare May 5, 2025 12:04
Copy link

github-actions bot commented May 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

For test bgp_redistribute_table there is a function that removes
unwanted json attributes.  Let's add receivedNexthopGroupId to
that list.

Signed-off-by: Donald Sharp <[email protected]>
Upper level protocols are sending down a list of nexthops
that a temporary nhg was created to hold it.  After
route resolution is done, this NHG is thrown away.
Let's keep this received NHG as a pointer off the RE.

Follow the `installedNexthopGroupId` pattern for display
purposes at this point in time.

Signed-off-by: Donald Sharp <[email protected]>
Add a simple test that does some basic exercising of the receivedNHGId
and that it worked as expected.

Signed-off-by: Donald Sharp <[email protected]>
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ton31337 ton31337 merged commit b0f36d0 into FRRouting:master May 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master size/L tests Topotests, make check, etc zebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants