Skip to content

SRv6: Add support for multiple SRv6 locators #18806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

SRv6: Add support for multiple SRv6 locators #18806

wants to merge 19 commits into from
+2,250 −553

Conversation

cscarpitta
Copy link
Contributor

This PR extends the SRv6 SID Manager to add support for multiple locators.

It includes some code refactoring to the SID Manager and adds the necessary changes to enable multiple locators.

@frrbot frrbot bot added libfrr tests Topotests, make check, etc labels May 13, 2025
mjstapp
mjstapp reviewed May 13, 2025
View reviewed changes
@raja-rajasekar raja-rajasekar mentioned this pull request May 16, 2025
Closed
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from 5447123 to 7d162e4 Compare May 18, 2025 23:24
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from 7d162e4 to d535aa0 Compare May 18, 2025 23:26
@cscarpitta cscarpitta marked this pull request as ready for review May 19, 2025 08:14
mjstapp
mjstapp reviewed May 27, 2025
View reviewed changes
@raja-rajasekar
Copy link
Contributor

Any update on this?

@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch 3 times, most recently from e32c75c to dfd666d Compare June 6, 2025 17:14
cscarpitta added 10 commits June 6, 2025 19:44
@cscarpitta
*: Add locator to SID release API
a3d7540 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
staticd: Fix SID structure
cbe243e 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
*: Support allocation of SRv6 local-only SID entries
cbd645f 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
staticd: Add support for local-only SIDs
4d00639 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Abstract APIs to manage SRv6 SID blocks
7e7be45 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Parse SIDs early
634bb93 
Decompose SID early as if the SID is invalid there is no point in moving forward

Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Add function to perform SID ctx lookup
70e477a 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Refactor get_srv6_sid_explicit
d9781b3 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Refactor get srv6 sid dynamic
ce71a08 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Refactor release srv6 sid
8defba8 
Move release srv6 sid function

Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch 3 times, most recently from a1a37eb to bd9a476 Compare June 7, 2025 00:30
cscarpitta added 9 commits June 7, 2025 07:48
@cscarpitta
zebra: Add data structure to store SIDs parent locators
d02e015 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Fix compose and decompose functions
00af92e 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Extend get SID APIs to support multiple locators
f6c1072 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Extend vty to show SIDs from multiple locators
445cb5a 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Notify daemons when SIDs are allocated
43e79d3 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Remove unused code
74a2666 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Move SRv6 SIDs data structure under the block
190ecf4 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
zebra: Pass locator when allocating SRv6 explicit SID
e0fb597 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta
tests: Add topotest for SRv6 multiple locators
fb51a53 
Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from bd9a476 to fb51a53 Compare June 7, 2025 07:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@raja-rajasekar
Copy link
Contributor

LGTM...
But you might want to address the ASAN warning in the latest run.

07-Jun-2025 08:32:06 | Address Sanitizer Error detected in bgp_srv6l3vpn_to_bgp_vrf3.test_bgp_srv6l3vpn_to_bgp_vrf3/r1.asan.zebra.1653
-- | --
07-Jun-2025 08:32:06 | Address Sanitizer Error detected in bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r1.asan.zebra.28224
07-Jun-2025 08:32:06 | Address Sanitizer Leak triggered - Test failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjstapp mjstapp mjstapp left review comments

@ahsalam ahsalam ahsalam approved these changes

Assignees
No one assigned
Labels
conflicts libfrr master size/XXL staticd tests Topotests, make check, etc zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cscarpitta @raja-rajasekar @mjstapp @ahsalam