Skip to content

SRv6: Add support for multiple SRv6 locators #18806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

cscarpitta
Copy link
Contributor

This PR extends the SRv6 SID Manager to add support for multiple locators.

It includes some code refactoring to the SID Manager and adds the necessary changes to enable multiple locators.

@frrbot frrbot bot added libfrr tests Topotests, make check, etc labels May 13, 2025
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from 5447123 to 7d162e4 Compare May 18, 2025 23:24
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from 7d162e4 to d535aa0 Compare May 18, 2025 23:26
@cscarpitta cscarpitta marked this pull request as ready for review May 19, 2025 08:14
@raja-rajasekar
Copy link
Contributor

Any update on this?

@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch 3 times, most recently from e32c75c to dfd666d Compare June 6, 2025 17:14
cscarpitta added 10 commits June 6, 2025 19:44
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Decompose SID early as if the SID is invalid there is no point in moving forward

Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Signed-off-by: Carmine Scarpitta <[email protected]>
Move release srv6 sid function

Signed-off-by: Carmine Scarpitta <[email protected]>
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch 3 times, most recently from a1a37eb to bd9a476 Compare June 7, 2025 00:30
@cscarpitta cscarpitta force-pushed the feature/srv6_multiple_locators branch from bd9a476 to fb51a53 Compare June 7, 2025 07:50
Copy link

github-actions bot commented Jun 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@raja-rajasekar
Copy link
Contributor

LGTM...
But you might want to address the ASAN warning in the latest run.

07-Jun-2025 08:32:06 | Address Sanitizer Error detected in bgp_srv6l3vpn_to_bgp_vrf3.test_bgp_srv6l3vpn_to_bgp_vrf3/r1.asan.zebra.1653
-- | --
07-Jun-2025 08:32:06 | Address Sanitizer Error detected in bgp_srv6l3vpn_to_bgp_vrf.test_bgp_srv6l3vpn_to_bgp_vrf/r1.asan.zebra.28224
07-Jun-2025 08:32:06 | Address Sanitizer Leak triggered - Test failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants