build: preliminary pkgconf .pc file (WIP) #18881
Conversation
NOT READY FOR USE YET, JUST WORK IN PROGRESS. UNTESTED. Signed-off-by: David Lamparter <[email protected]>
| # when packaging an FRR source/build tree, fill in the next line | ||
| # (e.g. with /usr/src/frr) | ||
| # | ||
| abs_top_treedir="FILL_TREEDIR_DURING_PACKAGING" |
There was a problem hiding this comment.
This file should be installed by make install into @PREFIX@/lib/pkgconfig. Also, you should replace FILL_TREEDIR_DURING_PACKAGING with @PREFIX@/src/frr-@VERSION@ to make downstream packaging easier. Also, all headers required to build dplane plugins should be installed in @PREFIX@/src/frr-@VERSION@ so that out of tree plugins can be compiled.
There was a problem hiding this comment.
autoconf doesn't have a "standard" path specifying command line option for /usr/src and I'm not sure it's a great idea to hardcode @PREFIX@/src/frr…. It probably makes sense to add a --with-headertree= or something, and have it default to @PREFIX@/src/frr-@VERSION@. This is all really just poking around right now, hence draft not PR.
| URL: @PACKAGE_BUGREPORT@ | ||
| Version: @PACKAGE_VERSION@ | ||
| Libs: -L${libdir} -rpath ${libdir} -lfrr | ||
| Cflags: -I${abs_top_treedir} -I${abs_top_treedir}/lib \ |
There was a problem hiding this comment.
It is missing -I${abs_top_treedir}/zebra to build dplane plugins?
| @@ -0,0 +1,30 @@ | |||
| # when packaging an FRR source/build tree, fill in the next line | |||
There was a problem hiding this comment.
There is no point in installing the whole build tree. Only certain headers are required for compiling dplane plugins: *.h, lib/*.h, zebra/*.h.
There was a problem hiding this comment.
yeah this was just poorly worded, the intention is the header files. I was calling it build because the linux kernel thing is sometimes called kbuild
NOT READY FOR USE YET, JUST WORK IN PROGRESS. UNTESTED.
cf. #18807