tests: Optimize topotest shutdown process #20030
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredmauch
force-pushed
the
test_runtime_improvements
branch
from
1e97b3d to
6305700
Compare
jaredmauch
force-pushed
the
test_runtime_improvements
branch
3 times, most recently
from
f3297de to
3285ba0
Compare
jaredmauch
force-pushed
the
test_runtime_improvements
branch
from
e9137b3 to
8fbfe54
Compare
jaredmauch
pushed a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
jaredmauch
pushed a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
Contributor
Author
jaredmauch
pushed a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <jared@debian>
jaredmauch
added a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
jaredmauch
added a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
jaredmauch
added a commit
to jaredmauch/frr
that referenced
this pull request
Nov 20, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
jaredmauch
added a commit
to jaredmauch/frr
that referenced
this pull request
Nov 23, 2025
Add missing scope check before accessing interface pointer when handling unknown LSAs with U-bit clear. AS-scope LSAs use process pointer, not interface, causing incorrect flooding behavior. Discovered during CI/CD testing of PR FRRouting#20030 in ospf6_point_to_multipoint test. Signed-off-by: jared mauch <[email protected]>
jaredmauch
force-pushed
the
test_runtime_improvements
branch
from
8fbfe54 to
5d09cbb
Compare
jaredmauch
force-pushed
the
test_runtime_improvements
branch
2 times, most recently
from
126f9d4 to
fca0610
Compare
Contributor
|
NOTE: working with @jaredmauch now to get this in. |
choppsv1
force-pushed
the
test_runtime_improvements
branch
4 times, most recently
from
af24683 to
20c5b77
Compare
The stop_topology() method previously stopped routers sequentially, which could be slow for topologies with many routers. This change optimizes the shutdown process by: 1) Sending SIGTERM to all daemons on all routers in parallel 2) Waiting for all daemons to stop together in a single loop 3) Force stopping any remaining daemons with SIGBUS 4) Collecting errors from all routers after shutdown - Also make the TopoGear.stop() API consistent. Signed-off-by: Jared Mauch <[email protected]> Signed-off-by: Christian Hopps <[email protected]>
Signed-off-by: Christian Hopps <[email protected]>
choppsv1
force-pushed
the
test_runtime_improvements
branch
from
20c5b77 to
a98610e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stop_topology() method previously stopped routers sequentially, which could be slow for topologies with many routers. This change optimizes the shutdown process by: