cl frr to upstream frr bfd commits #20327
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougatahitcs
force-pushed
the
sougatab/_cl-frr-to-upstream-frr-bfd-commits
branch
from
cb4fed1 to
d2b669f
Compare
…config for single hop static route bfd root@mid0:mgmt:/media/node/sougatab/debs/frr-upgrade# vtysh -c "conf t" -c "ip route 4.4.4.4/32 34.0.0.2 bfd profile pf1 source 34.0.0.1 vrf vrf1" root@mid0:mgmt:/media/node/sougatab/debs/frr-upgrade# vtysh -c "show run" | grep 4.4.4.4 ip route 4.4.4.4/32 34.0.0.2 bfd profile pf1 Ticket: # 4402283 Signed-off-by: Sougata Barik <[email protected]>
sougatahitcs
force-pushed
the
sougatab/_cl-frr-to-upstream-frr-bfd-commits
branch
from
d2b669f to
00c5bdd
Compare
Author
|
ci:rerun |
1 similar comment
Author
|
ci:rerun |
BFD profile information is essential, particularly in scenarios where multiple BFD clients use different profiles for the same session. In such cases, BFD ultimately applies the most recently updated profile. Currently, there is no way to determine which profile is configured and which one is actively in use. Ticket: #4653777 Signed-off-by: Sougata Barik <[email protected]>
sougatahitcs
force-pushed
the
sougatab/_cl-frr-to-upstream-frr-bfd-commits
branch
from
3a1e59b to
dc8b2d6
Compare
Author
|
ci:rerun |
donaldsharp
reviewed
Dec 27, 2025
| { | ||
| char addr_buf[INET6_ADDRSTRLEN]; | ||
|
|
||
| if (bs->profile_name) |
Member
There was a problem hiding this comment.
Doesn't this change break the table format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request includes two BFD-related commits that I would like to contribute upstream to FRR from Cumulus.
Log:
root@r1:/tmp/topotests/bgp_bfd_session.test_bgp_bfd_session/r1# vtysh -c "show run"
Building configuration...
Current configuration:
!
frr version 10.6-dev-MyOwnFRRVersion
frr defaults traditional
hostname r1
domainname localdomain
log commands
service integrated-vtysh-config
!
ip route 20.0.0.0/24 10.0.0.2 bfd profile pf1
!
interface r1-eth0
ip address 10.0.0.1/24
exit
!
router bgp 65000
neighbor PG peer-group
neighbor PG remote-as auto
neighbor PG bfd
neighbor PG bfd profile pf1
neighbor PG ebgp-multihop 15
neighbor PG update-source 10.0.0.1
neighbor PG2 peer-group
neighbor PG2 remote-as auto
neighbor PG2 bfd
neighbor PG2 bfd profile pf1
neighbor PG2 ebgp-multihop 25
neighbor 192.168.1.4 peer-group PG
neighbor 192.168.1.5 peer-group PG2
neighbor 192.168.1.5 update-source 10.0.0.1
neighbor 192.168.1.2 remote-as auto
neighbor 192.168.1.2 bfd
neighbor 192.168.1.2 bfd profile pf1
neighbor 192.168.1.2 ebgp-multihop 10
neighbor 192.168.1.2 update-source 10.0.0.1
neighbor 192.168.1.3 remote-as auto
neighbor 192.168.1.3 bfd
neighbor 192.168.1.3 bfd profile pf1
neighbor 192.168.1.3 ebgp-multihop 20
neighbor 192.168.1.3 update-source r1-eth0
exit
!
bfd
profile pf1
exit
!
exit
!
end
root@r1:/tmp/topotests/bgp_bfd_session.test_bgp_bfd_session/r1# vtysh -c "show bfd peers" | grep "profile|Profile"
Profile: pf1
Profile: pf1
Profile: pf1
Profile: pf1
Profile: pf1
root@r1:/tmp/topotests/bgp_bfd_session.test_bgp_bfd_session/r1# vtysh -c "show bfd peers json" | grep "profile|Profile"
"profile":"pf1",
"profile":"pf1",
"profile":"pf1",
"profile":"pf1",
"profile":"pf1",
root@r1:/tmp/topotests/bgp_bfd_session.test_bgp_bfd_session/r1# vtysh -c "show bfd static route"
Showing BFD monitored static routes:
Next hops:
VRF default IPv4 Unicast:
20.0.0.0/24 peer 10.0.0.2 (status: uninstalled)
root@r1:/tmp/topotests/bgp_bfd_session.test_bgp_bfd_session/r1#