Skip to content

Conversation

@hnattamaisub
Copy link
Contributor

Enabled lttng support in bfdd folder

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

bfdd/bfd.c Outdated
if (bs->key.vrfname[0]) {
vrf = vrf_lookup_by_name(bs->key.vrfname);
if (vrf == NULL) {
/* Trace VRF lookup failure */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go through the entire commit and clean up the unnecessary comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clean up the build and address the issues I have pointed out.

@hnattamaisub hnattamaisub force-pushed the lttng_bfd branch 8 times, most recently from 4a4f3e3 to d8f624b Compare January 6, 2026 12:53
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@hnattamaisub
Copy link
Contributor Author

ci:rerun

Copy link
Member

@donaldsharp donaldsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@hnattamaisub
Copy link
Contributor Author

ci:rerun

@hnattamaisub
Copy link
Contributor Author

ci:rerun

@hnattamaisub
Copy link
Contributor Author

ci:rerun

@ton31337
Copy link
Member

ton31337 commented Jan 8, 2026

Please fix the styling (frrbot) before merging.

Enabled lttng support in bfdd folder

Signed-off-by: harini <[email protected]>
@hnattamaisub
Copy link
Contributor Author

Please fix the styling (frrbot) before merging.

yes done. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants