fix: add FStar.Mul compat shim for nightly-2026-04-29 - #10
Open
zachary-kent wants to merge 1 commit into
Open
Conversation
FStar.Mul was removed and op_Multiply renamed to op_Star in this nightly. Add a shim that re-exports op_Multiply using the new infix operator, and add missing imports to two files that used op_Multiply without opening FStar.Mul. Closes FStarLang#8
|
@zachary-kent please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FStar.Mulwas removed in F* nightly-2026-04-29 (the pinned version insetup.sh), andop_Multiplywas renamed toop_Star. This breaks all 8 ISMM modules that depend on it.Fix
ismm/FStar.Mul.fstshim that re-exportsop_Multiplyusing the new infix*operatoropen FStar.MultoISMM.UnionFind.Spec.fstandISMM.UF.SizeRank.fstwhich usedop_Multiplywithout importing itVerification
Before: 163 passed, 9 failed (on main)
After: 171 passed, 1 failed (remaining failure is #7, unrelated filename issue)
Closes #8