Jump to fsti's when jumping to a module. Allow user preference for this. - #108
Open
jaybosamiya wants to merge 2 commits into
Open
Jump to fsti's when jumping to a module. Allow user preference for this.#108jaybosamiya wants to merge 2 commits into
jaybosamiya wants to merge 2 commits into
Conversation
Member
Author
|
This is very much a hack (I just check for whether the path+"i" exists), so I am not sure whether we should merge this in; however, it is a starting point for building the feature in, which is why I opened up a PR for it. @cpitclaudel I would strongly appreciate your thoughts on this. Thanks :) |
cpitclaudel
requested changes
Jun 3, 2019
cpitclaudel
left a comment
cpitclaudel
left a comment
Contributor
There was a problem hiding this comment.
Looks pretty good! I think what would be ideal would be to refactor this to reuse part of the implementation of fstar-visit-interface-or-implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #107.
Supports the user choosing whether they want this new feature.