You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your contribution! Could you tell us a little bit why this is important? I buy the changes related to which, but why get rid of bash? This complicates the behavior in that we can't really rely on bash-like wildcard expansion which in turn means that, if we want to "do things right", we have to use $(wildcard ) a lot in Makefiles. Also, if you're building kremlin, surely you must have bash installed somewhere, no?
On my local build, bash was not required, so I wrongly thought that I could simply swap it. That being said, from the CI (even tho I cannot access the log because it requries that I log-in with a Microsoft account, seriously?), it seems important. So yeah, you're right. I restored the SHELL to bash, and will install it on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, with this patch, I was able to compile Kremlin on a POSIX-friendly environment, which means:
whichby the POSIXcommand -vbashby POSIXshThis helps a little bit more the build process by removing two dependencies.