Allow const source buffers for EBufBlit#537
Merged
Merged
Conversation
Contributor
|
Looks good to me! Thanks so much. You might want to check other buffer operations like EBufFill to see if they require the same treatment. |
tahina-pro
added a commit
to FStarLang/pulse
that referenced
this pull request
Feb 18, 2025
this commit should go hand-in-hand with FStarLang/karamel#537
Member
Author
|
Thanks Jonathan! Lines 398 to 402 in 481d456 (and similarly for infer')
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FStarLang/pulse#326, I am introducing Pulse mutable slices, and I am turning slices into immutable slices. For their C implementation, I am introducing
constarray pointers.Then, I tried to refine the signature of corresponding memcpy operations so that the source pointer can be
const. However, Karamel rejects me with:This PR solves this issue by weakening the checks in
lib/Check.mlto allow immutable source buffers. The destination buffer must still be mutable, though.Everest green CI: https://github.com/project-everest/everest/actions/runs/13336176953