Simplify: fold comparisons between integers - #755
Open
mtzguido wants to merge 2 commits into
Open
Conversation
Member
Author
|
The failure here is legit since it depends on a fix I bundled into #754. The GH actions caches seem to be acting up too. I deleted a bunch of them and I think CI will now work. |
Paranoid check.
This deserves a look to make sure we're not messing up wrt overflow, promotion, etc. I think this is correct since 1) we keep the invariant that integer constants are in bounds (see the asserts) and 2) we are only folding comparisons where the width of the operator and the width of both constants exactly match.
mtzguido
force-pushed
the
fold-int-comparisons
branch
from
August 21, 2026 22:01
37fd1fa to
a6083bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deserves a look to make sure we're not messing up wrt overflow,
promotion, etc. I think this is correct since 1) we keep the invariant
that integer constants are in bounds (see the asserts) and 2) we are only
folding comparisons where the width of the operator and the width of
both constants exactly match.