opam: build with gmake on mac#582
Draft
amosr-msft wants to merge 1 commit into
Draft
Conversation
Author
|
related karamel change: FStarLang/karamel#682 |
The Makefile prohibits the default make found on MacOS, so `opam install` won't work by default, unless the user specifies to use gmake by eg setting opam's make env var. It seems reasonable to use gmake by default on MacOS. I added similar logic to karamel a few months ago.
amosr-msft
force-pushed
the
amos/20260226-opam-macos
branch
from
e256fc7 to
a69a52a
Compare
Author
|
I was able to get this building on our mac build servers, but then ran into unrelated problems with our infrastructure, so have had to shelve it for now. this change seems to be working but I'll park this for now until I can get our infrastructure problems sorted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile prohibits the default make found on MacOS, so
opam installwon't work by default, unless the user specifies to use gmake by eg setting opam's make env var.It seems reasonable to use gmake by default on MacOS. I added similar logic to karamel a few months ago. (Though, it turns out the implementation there was slightly wrong.)