92 simplify and update offshore cost model #169
Conversation
There was a problem hiding this comment.
I added some comments @mstargardt
Also we need the pipeline running for RESKit on Github before we can merge anything @julian-belina
| # Combine all costs | ||
| totalOffshoreCapex = ( | ||
| newTurbineCost + newFoundationCost + newCableCost + overheadCostBase | ||
| ) | ||
|
|
||
| return totalOffshoreCapex |
There was a problem hiding this comment.
also this function would profit from having the respective unit next to the variables
There was a problem hiding this comment.
The pipeline is up and running on the dev branch
There was a problem hiding this comment.
Very, very nice addition to the RESkit body, thanks @mstargardt !! Only one general question left, also to @phil-fzj - would we discontinue the "offshore_turbine_capex" function and related functions in offshore_cost_model.py then? They are very nice, but helplessly outdated and cannot be updated without a new, consistent datasource as far as I understand @mstargardt ?
|
I would propose ignoring the linting error and introducing linting in a new pull request. |
|
closes #156 |
|
added new commits. last test run needs to be done. |
4 participants
Added function to scale given OffshoreCapex regarding, wind speed, water depth and distance to the nearest coastline.
Test are included