Skip to content

Conversation

H-Wenzel
Copy link
Collaborator

@H-Wenzel H-Wenzel commented Aug 21, 2025

@julian-belina for some reason the macos pipeline fails while all others run through. Do you have an idea how this could be resolved?

closes #177

@H-Wenzel H-Wenzel requested a review from julian-belina August 21, 2025 15:35
@julian-belina
Copy link
Collaborator

@H-Wenzel, this looks strange. I've looked at your workflow, and it seems that you're mainly using SciPy as an external dependency. I can set up a small test tomorrow to check if it might be related to the SciPy version.

@phil-fzj
Copy link
Collaborator

phil-fzj commented Aug 21, 2025

didn´t we have a similar problem with scipy scikit-learn and tsam?
FZJ-IEK3-VSA/tsam#101

@julian-belina
Copy link
Collaborator

julian-belina commented Aug 22, 2025

@Phil_FZJ, I don't think these issues are necessarily related.

@H-Wenzel
I ran a small test pipeline, and lowering the SciPy version seems to have fixed the issue. However, I also don't know what the actual cause is.

https://github.com/julian-belina/RESKit/actions/runs/17158022951/job/48679756967

@H-Wenzel
Copy link
Collaborator Author

@julian-belina alright, weird. Thanks for checking! Since the pipeline passed with the lower scipy version, I suppose it can be merged?

@julian-belina
Copy link
Collaborator

I think it can be merged for now. We can check later how we can upgrade to newer scipy versions

@H-Wenzel H-Wenzel requested a review from phil-fzj August 26, 2025 14:29
Copy link
Collaborator

@phil-fzj phil-fzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor things left

Copy link
Collaborator

@phil-fzj phil-fzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. ready to merge

@H-Wenzel H-Wenzel merged commit da32fe0 into dev Aug 27, 2025
14 checks passed
@phil-fzj phil-fzj deleted the 177-add_DAC_wf branch August 29, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants