-
Notifications
You must be signed in to change notification settings - Fork 20
177 add dac wf #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
177 add dac wf #181
Conversation
…electrified high temperature (HT, liquid solvent) DAC plants
…its of the output variables
@H-Wenzel, this looks strange. I've looked at your workflow, and it seems that you're mainly using SciPy as an external dependency. I can set up a small test tomorrow to check if it might be related to the SciPy version. |
didn´t we have a similar problem with |
@Phil_FZJ, I don't think these issues are necessarily related. @H-Wenzel https://github.com/julian-belina/RESKit/actions/runs/17158022951/job/48679756967 |
@julian-belina alright, weird. Thanks for checking! Since the pipeline passed with the lower scipy version, I suppose it can be merged? |
I think it can be merged for now. We can check later how we can upgrade to newer scipy versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor things left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. ready to merge
@julian-belina for some reason the macos pipeline fails while all others run through. Do you have an idea how this could be resolved?
closes #177