Skip to content

Hotfix RetargetBasePose being null when it shouldn't#279

Open
neptuwunium wants to merge 1 commit into
FabianFG:masterfrom
neptuwunium:fix/hotfix-anim-retargeting
Open

Hotfix RetargetBasePose being null when it shouldn't#279
neptuwunium wants to merge 1 commit into
FabianFG:masterfrom
neptuwunium:fix/hotfix-anim-retargeting

Conversation

@neptuwunium

@neptuwunium neptuwunium commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Hotfixes an issue that happens when one of the two is comparing via index and the other via strings (I think? I tried forcing GetHashCode to evaluate the string content and it did not fix it.)

Additive animations (usually faces) and animations using a shared skeleton end up being catastrophically distorted without this change.

Note; if it is an issue with FName comparison in Dictionary<FName, TValue> this issue could emerge in other places

@LongerWarrior

Copy link
Copy Markdown
Collaborator

Is there any specific game with this issue?

@neptuwunium

Copy link
Copy Markdown
Contributor Author

Fragpunk character animations.

@4sval

4sval commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

This is a global issue with FNames as the comparison is most of the time performed via Index/Number rather than Text value.
If 2 FNames are from 2 different name maps the numeric comparison will most likely fail.
It has already been an issue in the past with blueprint decompilation see this

@neptuwunium

Copy link
Copy Markdown
Contributor Author

I believe the unreal way is to hash the names and compare that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants