Add test-api-v1 (feat: Scoped Events) by Kilip1000 · Pull Request #5285 · FabricMC/fabric-api

Kilip1000 · 2026-03-29T22:28:33Z

Add fabric-dev-debug-api-v1, featuring EventScopes.

# Conflicts: # gradle.properties

Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>

# Conflicts: # fabric-debug-api-v1/src/main/java/net/fabricmc/fabric/mixin/debug/EntityMixin.java # fabric-debug-api-v1/src/main/java/net/fabricmc/fabric/mixin/debug/MobMixin.java

….debug.v1`

# Conflicts: # gradle.properties

refactor: ServerMobEffectsGameTest now uses EventScopes, an api introduced through the fabric-debug-api-v1 module

sylv256

Overall, good for now. Obviously we're going to need docs and some unit tests, but there are some other considerations, most of which are small. One huge concern, though, is that the ServiceLoader system will apply outside of development environments. Is there any way we can ensure it only applies in dev?

I am at least glad that we don't have MODMUSS_RETURN_EVENT and EncapsulationBreaker3000 anymore.

Edit: small nitpick, but could you write a description in compliance with the CONTRIBUTING.md?

...v1/src/main/resources/META-INF/services/net.fabricmc.fabric.impl.base.event.EventFactoryImpl

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/EventFactoryImpl.java

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/EventPhaseData.java

fabric-dev-debug-api-v1/src/main/java/net/fabricmc/fabric/api/debug/dev/v1/EventScope.java

fabric-debug-api-v1/src/main/java/net/fabricmc/fabric/api/test/EventScope.java

...rc/testmod/java/net/fabricmc/fabric/test/entity/event/gametest/ServerMobEffectsGameTest.java

sylv256 · 2026-03-30T00:11:28Z

Can you move things to a new dev-only module called fabric-dev-debug-api-v1? That'll help reduce the complexity here and resolve a few issues. Rationale below, discussion in Discord.

In lieu of some kind of dev-only child module for Debug API, we should make a dev-only module called fabric-dev-debug-api-v1. If we could, we would go back in time and rename fabric-gametest-api-v1 to fabric-test-api-v1, but we obviously can't, so to avoid another GameTest API situation, fabric-dev-debug-api-v1 makes more sense for a dev-only version of Debug API which will only have Scoped Events for now.

sylv256 · 2026-03-30T13:36:42Z

Can you move things to a new dev-only module called fabric-dev-debug-api-v1?

I'll do this later.

…scope

sylv256

LGTM, though I'm not sure if we need more events or not. I know Modmuss's original PR had a lot, but I'm pretty sure that was due to its jankiness.
Also, should it be called EventScope#registerScoped, EventScope#registerEvent, or something else entirely?

sylv256

Already reviewed, same comments as above.

Earthcomputer

Also not sure about the name of EventScope.registerScoped, but everything else looks fine

sylv256 · 2026-03-30T23:50:21Z

Also not sure about the name of EventScope.registerScoped, but everything else looks fine

I think EventScope.registerEvent should make it clearer what it does without repeating itself.

Earthcomputer · 2026-03-30T23:52:18Z

I don't like registerEvent, it makes it sound like you're registering an event. registerScoped is better, or maybe just register.

sylv256 · 2026-03-30T23:52:40Z

I think I'll just go with register.

modmuss50

Sorry to be blunt but I'm really not keen on this approach, its ripping open the event api in all the ways that go against good API design. I think we can do better where we dont need to undermine the existing event API but its going to need some thought. I dont have the magic solution at the moment in the past I have tried using reflection to achieve this in a way that wraps the event.

settings.gradle

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/ArrayBackedEvent.java

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/EventFactoryImpl.java

fabric-test-api-v1/src/testmod/java/net/fabricmc/fabric/test/EventScopeTest.java

fabric-dev-debug-api-v1/src/main/resources/fabric.mod.json

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/EventFactoryImpl.java

address feedback

This reverts commit 6ea9b07.

…ect its scope" This reverts commit 8cd5b48.

Earthcomputer and others added 20 commits December 15, 2025 15:15

Add testable events

33da0f8

feat: Debug API

278ac4c

Merge remote-tracking branch 'origin/26.1' into debug-api

c22b43f

# Conflicts: # gradle.properties

docs(EntityDebugSubscriptionRegistry): clarify it's server-side only

b7ec842

chore: apply licenses

9f343f0

docs: Constructor -> Factory terminology on factory interfaces

2309980

Merge remote-tracking branch 'origin/26.1' into debug-api

1edea23

# Conflicts: # gradle.properties

fix: depend fabricloader >=0.18.4

f0a43db

refactor: merge MobMixin & EntityMixin

9754e49

use @APinote in javadoc and use package-private Mixins

c3ac770

Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>

Merge remote-tracking branch 'origin/debug-api' into debug-api

9f77b0b

# Conflicts: # fabric-debug-api-v1/src/main/java/net/fabricmc/fabric/mixin/debug/EntityMixin.java # fabric-debug-api-v1/src/main/java/net/fabricmc/fabric/mixin/debug/MobMixin.java

refactor!: net.fabricmc.fabric.api.debug.v1.client -> `….api.client…

d3271d8

….debug.v1`

Merge remote-tracking branch 'origin/26.1' into debug-api

77e5364

# Conflicts: # gradle.properties

Merge branch '26.1' into debug-api

a4ed9e8

Merge remote-tracking branch 'origin/26.1' into debug-api

651b2d8

# Conflicts: # gradle.properties

Merge branch 'test-event-scopes' into debug-api

d7a70e9

Move event scopes to debug api

dffdb53

refactor: ServerMobEffectsGameTest now uses EventScopes

2cc663f

refactor: ServerMobEffectsGameTest now uses EventScopes, an api introduced through the fabric-debug-api-v1 module

Merge branch '26.1' into debug-api

14c1700

spotless apply

64235c9

sylv256 added the enhancement New feature or request label Mar 29, 2026

sylv256 self-requested a review March 29, 2026 22:36

sylv256 suggested changes Mar 29, 2026

View reviewed changes

sylv256 mentioned this pull request Mar 29, 2026

(Spaghetti Warning!) [Testing] Event Scopes #5041

Closed

Kilip1000 requested a review from sylv256 March 30, 2026 00:35

Kilip1000 force-pushed the debug-api branch from 759eacf to fd8f86e Compare March 30, 2026 13:11

Kilip1000 force-pushed the debug-api branch 2 times, most recently from 228df1f to 6d4b306 Compare March 30, 2026 16:15

sylv256 added 5 commits March 30, 2026 18:16

docs(EventScope): nitpick changes to phrasing and word choice

32effd1

test: add tests for EventScope

bddd1d5

docs: change description of Debug API to more accurately reflect its …

8cd5b48

…scope

fix: remove unnecessary dev env check

1fc8725

refactor: move merge EventTestingImpl with EventScopeImpl

08382c5

sylv256 approved these changes Mar 30, 2026

View reviewed changes

chore: spotless apply

c5753e1

Kilip1000 marked this pull request as ready for review March 30, 2026 23:20

Kilip1000 requested a review from sylv256 March 30, 2026 23:20

sylv256 approved these changes Mar 30, 2026

View reviewed changes

sylv256 requested a review from Earthcomputer March 30, 2026 23:34

Earthcomputer approved these changes Mar 30, 2026

View reviewed changes

sylv256 added 2 commits March 30, 2026 19:54

refactor: EventScope#registerScoped -> #register

6e715f3

Merge branch '26.1' into debug-api

52d19fd

modmuss50 requested changes Mar 31, 2026

View reviewed changes

sylv256 reviewed Mar 31, 2026

View reviewed changes

fabric-api-base/src/main/java/net/fabricmc/fabric/impl/base/event/EventFactoryImpl.java Show resolved Hide resolved

Kilip1000 and others added 6 commits April 1, 2026 23:15

remove hacky inheritor verification

6ea9b07

address feedback

mark api as stable

85b6147

Revert "remove hacky inheritor verification"

a8e7e0e

This reverts commit 6ea9b07.

fix: remove inheritance check & ServiceLoader jank, use custom FMJ value

39d745f

chore: mark API experimental

b6c31d4

Revert "docs: change description of Debug API to more accurately refl…

68e2541

…ect its scope" This reverts commit 8cd5b48.

Kilip1000 changed the base branch from 26.1 to 26.1.1 April 2, 2026 00:09

sylv256 added 2 commits April 1, 2026 20:10

refactor: remove reliance on Debug API, convert to test-api

371d949

Merge branch '26.1.1' into debug-api

903bb29

Kilip1000 changed the title ~~Add dev-debug-api-v1 (feat: Scoped Events)~~ Add test-api-v1 (feat: Scoped Events) Apr 2, 2026

test: convert gametest to unit test

c146b32

Conversation

Kilip1000 commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylv256 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sylv256 commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sylv256 commented Mar 30, 2026

Uh oh!

sylv256 left a comment

Choose a reason for hiding this comment

Uh oh!

sylv256 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Earthcomputer left a comment

Choose a reason for hiding this comment

Uh oh!

sylv256 commented Mar 30, 2026

Uh oh!

Earthcomputer commented Mar 30, 2026

Uh oh!

sylv256 commented Mar 30, 2026

Uh oh!

modmuss50 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kilip1000 commented Mar 29, 2026 •

edited

Loading

sylv256 left a comment •

edited

Loading

sylv256 commented Mar 30, 2026 •

edited

Loading

sylv256 left a comment •

edited

Loading