Generate @NullMarked package infos directly into the src dir#5355
Generate @NullMarked package infos directly into the src dir#5355DennisOchulor wants to merge 6 commits intoFabricMC:26.1.2from
Conversation
|
This is just going to create a ton of spam in commits. It's not worth it IMO |
We could exclude I feel the better IDE integration is worth it, this is very likely the exact same thing Mojang does as well. |
How is that even possible? It's going to be in the diff anyway so we don't exclude regular |
The generation code checks if there is an existing package-info and throws an error if it is not |
Either way, it's going to make it more difficult to find the |
|
I think this is the only solution, its a real shame intelij cannot figure it out even though they are already present in the Loom does the same as this: FabricMC/fabric-loom#1443 its not ideal but I dont have a better solution. In the long run I'd love to expand the IDE warnings to be CI build failuires, im not sure how feasible that is however. |
This allows IDEs to actually give out nullability warnings to FAPI devs.
I've also renamed
generatePackageInfostogenerateMainPackageInfosandcheckPackageInfostocheckMainPackageInfosto make it clear that it only involves the main sourceset. Also added anapplyFixupstask to runspotlessApply,generateMainPackageInfosandgenerateClientPackageInfosall at once.I've not committed the generated package infos yet to ease reviewing.