Class Tweakers: Introduction & Access Widening#517
Class Tweakers: Introduction & Access Widening#517its-miroma merged 33 commits intoFabricMC:mainfrom
Conversation
…r than classtweaker, add non-GitHub wiki editors to accesswidening.md
…Fabric Loader version constraints
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
its-miroma
changed the title
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
I'm reviewing the other file also
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
Here's the other file, reviewed
Some suggestions may not have been applied or applied differently at my own discretion. Rereview will be needed to evaluate my decisions. Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
…ieldName and fieldDescriptor
whoops, forgot that one in the previous commit! Co-authored-by: Miroma <its.miroma@proton.me>
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
|
As this PR nears being merged, some special thanks to @cassiancc for their support and help with linting and build issues; and to @its-miroma for their many contributions for formatting, phrasing and very thorough reviewing process. Future plans for the Class Tweaker section of the Docs include notably a page on interface injection, and when it is released a page on the upcoming enum extension feature. |
cassiancc
left a comment
cassiancc
left a comment
There was a problem hiding this comment.
Good to go by me! Should just need the last of Miroma's tweaks applied and I think we're good to merge.
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
Co-authored-by: Miroma <136986257+its-miroma@users.noreply.github.com>
4 participants
This (WIP) PR has two main goals:
This includes, for the Docs themselves a new section, placed currently between Mixins and Misc. Pages, with an introduction page and an access widening page.
For the reference mod, this includes adding a new
example-mod.classtweakerfile to the resources, and fixing the FMJ's emptydependsblock since class tweakers require Loader 0.18.0+ to work.The other wiki page on class tweakers, for interface injection will be added in a later PR.
This PR isn't complete yet, but it's complete enough for early reviews. Particularly would like a review from @Earthcomputer as he was one of the primary editors behind updating the access widener wiki page to use class tweaker.