Skip to content

Handle multiple FabricLoaderLauncherSessionListener instances. #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Handle multiple FabricLoaderLauncherSessionListener instances. #1003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df1ea2
Handle multiple FabricLoaderLauncherSessionListener instances.
modmuss50 Nov 30, 2024
fbf5860
Fix
modmuss50 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion junit/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ repositories {
dependencies {
api project(":")

api platform("org.junit:junit-bom:5.10.0")
api platform("org.junit:junit-bom:5.11.3")
api "org.junit.jupiter:junit-jupiter-engine"
implementation "org.junit.platform:junit-platform-launcher"
}
Expand Down
12 changes: 10 additions & 2 deletions junit/src/main/java/net/fabricmc/loader/impl/junit/FabricLoaderLauncherSessionListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,20 @@ public class FabricLoaderLauncherSessionListener implements LauncherSessionListe
System.setProperty(SystemProperties.UNIT_TEST, "true");
}

private final Knot knot;
private final ClassLoader classLoader;
private static Knot knot = null;
private static ClassLoader classLoader = null;

private ClassLoader launcherSessionClassLoader;

public FabricLoaderLauncherSessionListener() {
setup();
}

private static synchronized void setup() {
if (knot != null) {
return;
}

final Thread currentThread = Thread.currentThread();
final ClassLoader originalClassLoader = currentThread.getContextClassLoader();

Expand Down