Skip to content

Conversation

@williambl
Copy link

Super quick implementation of the first/main part (i.e. not 'Further options') of #1081.

I'm not sure if this is worth writing tests for?

As the logic of the new `getConfigDirectory0` function is very similar to the existing `getModsDirectory0`, I abstracted them both into `getConfiguredOrRelativeDirectory`, which I honestly didn't name very well, which retrieves a path from a system property or, as a fallback, as a predefined path relative to the game directory.
// a comma-separated list of mod ids to disable, even if they're discovered. mostly useful for unit testing.
public static final String DISABLE_MOD_IDS = "fabric.debug.disableModIds";
// a path to a directory to replace the default mod config directory
public static final String CONFIG_FOLDER = "fabric.configFolder";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this next to the modsFolder property, probably above it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants