Add cache directory API #906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modmuss50
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Seems reasonable, I'm quite wary about moving .fabric, as its used by a few other things such as the installer.
I would expect modpack tools to just ingore all .*/, so having .fabric and .cache doesnt seem the end of the world. If it is just move .cache to .fabric/cache
src/main/java/net/fabricmc/loader/impl/game/GameProviderHelper.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a standardized cache directory API for mods (and loader) to use.
I'd like to see Fabric Loader (and hopefully also mods) adopt the usage of a standardized cache directory to remove clutter of temporary files mixed with regular game and config files, as well as allowing modpack tooling to ignore these files across the board.
Previously I've added a similar feature to Quilt Loader which has been adopted by some mods, and have contributed to Prism Launcher to ignore this folder when exporting instances or modpacks, which I believe especially helps new modpack creators decide which files they should and shouldn't include in their pack.