Feature/mixin improvements #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LlamaLad7
force-pushed
the
feature/mixin-improvements
branch
from
c6f4c50 to
4276f92
Compare
modmuss50
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is to ignore Mixin
remapvalues and just soft-fail if the name isn't remappable, like everywhere else. This is desirable for the user and simplifies the code quite a lot.I tested this on the latest fabric-api and it produces a jar which is identical to that with
tiny-remapper#master, as judged by runningjardiffon all the nested jars.However, the produced jar crashes due to some remapped accessor methods, hence my second commit. It is deeply undesirable to change the actual name of user-defined
Accessors andInvokers, so instead if the name is meant to be inferred, we add the remapped name to the annotation.This is enough to build a fully working FAPI. Commits should be reviewed individually and not squashed.