Skip to content

Further fix for Text Filtering when using Custom Blacklist #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Further fix for Text Filtering when using Custom Blacklist #2206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion libraries/fabrik/fabrik/Helpers/Worker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1620,7 +1620,18 @@ public static function getContentFilter()
{
// Remove the white-listed attributes from the black-list.
$tags = array_diff($blackListTags, $whiteListTags);
$filter = JFilterInput::getInstance($tags, array_diff($blackListAttributes, $whiteListAttributes), 1, 1);

// Here we want to seperate CBL from BL, in order to make the proper call to JFilterInput::getInstance
// This is because for CBL we want to pass the parameter $xssAuto as 0, so it will only perform the essential clean
// Otherwhise it will always perform the full blacklist cleanup
// Helpful resources: https://stackoverflow.com/a/42729709/1739313
// https://api.joomla.org/cms-3/classes/Joomla.CMS.Filter.InputFilter.html#method_getInstance
// getInstance(array $tagsArray = array(), array $attrArray = array(), integer $tagsMethod, integer $attrMethod, integer $xssAuto = 1, integer $stripUSC = -1) : \Joomla\CMS\Filter\InputFilter
if ($filterType == 'CBL') {
$filter = JFilterInput::getInstance($tags, array_diff($blackListAttributes, $whiteListAttributes), 1, 1, 0);
} else {
$filter = JFilterInput::getInstance($tags, array_diff($blackListAttributes, $whiteListAttributes), 1, 1);
}
}
// White lists take third precedence.
elseif ($whiteList)
Expand Down