Dynamic keybinds in MMH #857
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madis0
commented
Jun 17, 2024
| "modmenu.summaryTranslation.entityculling": "Stops rendering mobs behind walls\n§8🛠 (only advanced options)", | ||
| "modmenu.summaryTranslation.fabricskyboxes": "Custom Sky\n§3§l📥§r§9🛠§8 Expand the mod to configure (click ▼ on icon)", | ||
| "modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with F9\n§9🛠§8 Override F2, resolution, keybind, ...", | ||
| "modmenu.summaryTranslation.fabrishot": "Take 4K screenshots with <keybind 'key_key.fabrishot.screenshot'>\n§9🛠§8 Override <keybind 'key_key.screenshot'>, resolution, keybind, ...", |
Member
Author
There was a problem hiding this comment.
Even when MMH one is correct, the pause menu one won't be... But it's better than nothing I guess.
Member
Author
There was a problem hiding this comment.
In testing with MM 12.0.0 for 1.21.3 and TP API 2.5.1+1.21.3, the mod keybind crashed while the vanilla one worked. Maybe due to not being available in early loading yet?
[17:25:18] [Render thread/ERROR]:Reported exception thrown!
net.minecraft.class_148: Rendering screen
at knot/net.minecraft.class_757.method_3192(class_757.java:558) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1523(class_310.java:1352) ~[client-intermediary.jar:?]
at knot/net.minecraft.class_310.method_1514(class_310.java:933) [client-intermediary.jar:?]
at knot/net.minecraft.client.main.Main.main(Main.java:265) [client-intermediary.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NullPointerException: Cannot invoke "String.length()" because "string" is null
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser$Format.findFirst(TagLikeParser.java:368) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.impl.textparser.SingleTagLikeParser.handleLiteral(SingleTagLikeParser.java:21) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parse(TagLikeParser.java:82) ~[placeholder-api-2.5.1+1.21.3.jar:?]
at knot/eu.pb4.placeholders.api.parsers.TagLikeParser.parseNodes(TagLikeParser.java:75) ~[placeholder-api-2.5.1+1.21.3.jar:?]
Madis0
commented
Oct 29, 2024
Madis0
commented
Jan 7, 2025
Remove single-quotes
Madis0
force-pushed
the
mmh-improvement
branch
from
94a467e to
c27e85c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New cool stuff in 1.21 due to the added support of QuickText. Needs testing!