Fix lobbies always being discoverable by everyone briefly after lobby creation#850
Open
Fobri wants to merge 1 commit intoFacepunch:masterfrom
Open
Fix lobbies always being discoverable by everyone briefly after lobby creation#850Fobri wants to merge 1 commit intoFacepunch:masterfrom
Fobri wants to merge 1 commit intoFacepunch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had an issue in my game where random people were able to join friends only lobbies uninvited.
This caused various issues, most notably someone made an automatic bot which would join any possible lobbies with a modded client to cause all sorts of issues, griefing random players' games.
The issue is, if you set the lobby type to invisible, it can still be seen by search queries, as is apparent in Steamworks docs:
k_ELobbyTypeInvisible: Returned by search, but not visible to other friends.Even if you instantly change the lobby type after creation, it will still show up in search queries for a few seconds. This means that for any malicious party it is trivial to just keep spamming the search query and collect a list of all lobbies that have been created, and since friends only lobbies are joinable by anyone with the lobby id, this creates an issue.
After changing the lobby type to private on creation as per this commit, the issue was resolved.