Save launcher geometry when using 'Close On Launch'#10090
Closed
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Closed
Save launcher geometry when using 'Close On Launch'#10090boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Fixes position not being saved when using "Close On Launch"
boxrocket6803
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the launcher window's position and size were not being saved when the "Close On Launch" feature was enabled. When users launch a project with this option enabled, the window is destroyed programmatically without triggering the normal close handler that saves the geometry.
Changes:
- Added geometry saving before window destruction in the
OnSuccessfulLaunch()method to ensure window position is persisted when using "Close On Launch"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cookie for the launcher geometry was being saved when manually closing the window, but not when the window was automatically closed (e.g. when opening an addon with close on launch enabled), this saves the geometry for both cases.
Motivation & Context
Annoyed me, sometimes the launcher would get stuck in weird places for weeks on end.
Checklist