Allow [ShowIf] and [HideIf] to check for null#10133
Closed
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Closed
Allow [ShowIf] and [HideIf] to check for null#10133boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates conditional inspector visibility attributes to correctly support null comparisons when evaluating against SerializedObject, aligning [HideIf] / [ShowIf] behavior with expected “value is null” checks in the Editor inspector.
Changes:
- Stop passing the
SerializedObjectinstance as thedefaultValuetoSerializedProperty.GetValue<T>(), allowingnullproperty values to remainnull. - Ensure
[HideIf]/[ShowIf]can matchValue == nullas intended.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HideIfAttribute (and by extension ShowIfAttribute) previously wouldn't function when using null as the value, now they do.
Motivation & Context
slight annoyance, easy fix
Implementation Details
The entire SerializedObject was being passed into
SerializedProperty.GetValue(object defaultValue)as the default (such that if the properties value was null it would check against the serialized object rather than the property and always return false). I'm assuming this to be unintentional.Checklist