hide and rename _d files with same logic as _c files#10142
Closed
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Closed
hide and rename _d files with same logic as _c files#10142boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the editor asset browser/list behavior to treat “blob” data files (*_d) similarly to compiled files (*_c): they’re hidden when a corresponding source asset is present, and they’re renamed alongside compiled outputs when renaming the source.
Changes:
- Rename
*_dblob file alongside the compiled*_cfile when renaming an asset. - Hide
*_dblob files in the Asset Browser when a source asset exists (mirrors existing_cfiltering behavior). - Prevent blobs from being treated as loadable assets/inspectable items in the Asset Browser UI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
game/addons/tools/Code/Editor/AssetList/Entries/AssetEntry.cs |
Renames associated *_d blob file when renaming an asset (in addition to the compiled output). |
game/addons/tools/Code/Editor/AssetBrowser/AssetBrowser.cs |
Filters blob files out of the Asset Browser list when a source asset exists, using the same approach as compiled-file filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
handsomematt
added
the
triaged
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hides blob data files if a source file is present, if the source file is renamed it will rename the blob data in addition to the compiled file.
Motivation & Context
Seemed messy to have them all out in the open like that.
Checklist