Show volume tooltip in settings as a percentage rather than a decimal#102
Show volume tooltip in settings as a percentage rather than a decimal#102DrakeFruit wants to merge 1 commit intoFacepunch:masterfrom
Conversation
|
You make a nice PR that make sense, and then you change volume from 0-1 to 0-2 |
|
200% volume is something I wish a lot more programs had, 100% is the default that everyone targets but what happens when I need it louder than that? I could turn up my system volume but then everything else is too loud and I have to go through 5 programs and adjust the volume just to play s&box and every new program I install would be blasting until I turn it down. I could remove it from the settings menu but a higher limit via console is much appreciated. |
|
I don't really know why there is a limit on the console command |
d3411fb to
ece28f2
Compare
1e92499 to
1b80ecd
Compare
|
@garrynewman I removed the max part of the volume convars and set the max to 1 in the in game settings again. Thanks for the feedback |
this change also removes the max volume from volume settings, there's not really a reason to have one
a7749ed to
b89c366
Compare
|
This PR has been merged upstream. |
Also increases the max volume from 100% to 200% because 100% is quieter than everything else on my pc and it's nice to have