Skip to content

Show volume tooltip in settings as a percentage rather than a decimal#102

Closed
DrakeFruit wants to merge 1 commit intoFacepunch:masterfrom
DrakeFruit:Mixer-Settings-Menu
Closed

Show volume tooltip in settings as a percentage rather than a decimal#102
DrakeFruit wants to merge 1 commit intoFacepunch:masterfrom
DrakeFruit:Mixer-Settings-Menu

Conversation

@DrakeFruit
Copy link
Copy Markdown
Contributor

Also increases the max volume from 100% to 200% because 100% is quieter than everything else on my pc and it's nice to have

@garrynewman
Copy link
Copy Markdown
Member

You make a nice PR that make sense, and then you change volume from 0-1 to 0-2

@DrakeFruit
Copy link
Copy Markdown
Contributor Author

DrakeFruit commented Dec 9, 2025

200% volume is something I wish a lot more programs had, 100% is the default that everyone targets but what happens when I need it louder than that?

I could turn up my system volume but then everything else is too loud and I have to go through 5 programs and adjust the volume just to play s&box and every new program I install would be blasting until I turn it down.

I could remove it from the settings menu but a higher limit via console is much appreciated.

@garrynewman
Copy link
Copy Markdown
Member

I don't really know why there is a limit on the console command

@DrakeFruit DrakeFruit force-pushed the Mixer-Settings-Menu branch 3 times, most recently from d3411fb to ece28f2 Compare December 10, 2025 07:01
@DrakeFruit DrakeFruit closed this Dec 10, 2025
@DrakeFruit DrakeFruit reopened this Dec 10, 2025
@DrakeFruit
Copy link
Copy Markdown
Contributor Author

@garrynewman I removed the max part of the volume convars and set the max to 1 in the in game settings again. Thanks for the feedback

@DrakeFruit DrakeFruit closed this Dec 11, 2025
@DrakeFruit DrakeFruit reopened this Dec 11, 2025
this change also removes the max volume from volume settings, there's not really a reason to have one
@handsomematt handsomematt added triaged triaged pull-requests are replicated on the internal sbox repo and removed triaged triaged pull-requests are replicated on the internal sbox repo labels Jan 6, 2026
@sboxbot sboxbot added the accepted this pull request was accepted, hurrah! label Jan 7, 2026
@sboxbot
Copy link
Copy Markdown
Contributor

sboxbot commented Jan 7, 2026

This PR has been merged upstream.

@sboxbot sboxbot closed this Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted this pull request was accepted, hurrah! triaged triaged pull-requests are replicated on the internal sbox repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants