Move texture editor into inspector#10324
Closed
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Closed
Move texture editor into inspector#10324boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
Conversation
lolleko
reviewed
Mar 31, 2026
| namespace Editor.Inspectors; | ||
|
|
||
| [EditorForAssetType( "__fallback" )] | ||
| [EditorForAssetType( "__fallback" ), EditorForAssetType( "vtex" )] |
Contributor
There was a problem hiding this comment.
rest of the changes look okay on first glance, but this seems like a terrible hack
Contributor
Author
There was a problem hiding this comment.
best as I can tell that's the cleanest way to do it, __fallback is only for game resources, vtex isn't a game resource but should still use that editor (which is just the asset inspector in a window). There isn't really any clean way to differentiate between a non game resource asset that should use the inspector (aka just vtex) and an asset that should open in an external tool/ not open at all
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Texture editor is just asset browser inspector and preview, all those things are already present in the main editor. This moves the properties from the texture editor window into the normal inspector and completely removes the texture editor tool.
Motivation & Context
Standardizes things a bit, saves having to open a whole separate window.
Implementation Details
There's a lot of stuff in AssetInspector set up specifically for GameResource, I've extended it slightly to allow inspectors to hijack the unsaved changes popup if they provide their own OnSave and OnReset actions.
Screenshots
Checklist