Skip to content

Move texture editor into inspector#10324

Closed
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803:texture-inspector
Closed

Move texture editor into inspector#10324
boxrocket6803 wants to merge 1 commit intoFacepunch:masterfrom
boxrocket6803:texture-inspector

Conversation

@boxrocket6803
Copy link
Copy Markdown
Contributor

Summary

Texture editor is just asset browser inspector and preview, all those things are already present in the main editor. This moves the properties from the texture editor window into the normal inspector and completely removes the texture editor tool.

Motivation & Context

Standardizes things a bit, saves having to open a whole separate window.

Implementation Details

There's a lot of stuff in AssetInspector set up specifically for GameResource, I've extended it slightly to allow inspectors to hijack the unsaved changes popup if they provide their own OnSave and OnReset actions.

Screenshots

image

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

namespace Editor.Inspectors;

[EditorForAssetType( "__fallback" )]
[EditorForAssetType( "__fallback" ), EditorForAssetType( "vtex" )]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest of the changes look okay on first glance, but this seems like a terrible hack

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best as I can tell that's the cleanest way to do it, __fallback is only for game resources, vtex isn't a game resource but should still use that editor (which is just the asset inspector in a window). There isn't really any clean way to differentiate between a non game resource asset that should use the inspector (aka just vtex) and an asset that should open in an external tool/ not open at all

@handsomematt handsomematt added the triaged triaged pull-requests are replicated on the internal sbox repo label Apr 5, 2026
@sboxbot sboxbot added the accepted this pull request was accepted, hurrah! label Apr 7, 2026
@sboxbot
Copy link
Copy Markdown
Contributor

sboxbot commented Apr 7, 2026

This PR has been merged upstream.

@sboxbot sboxbot closed this Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted this pull request was accepted, hurrah! triaged triaged pull-requests are replicated on the internal sbox repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants