Skip to content

Prevent package closed toast from being dismissed on click#10344

Closed
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
RumBugen:fix/gameinfo-closed-10342
Closed

Prevent package closed toast from being dismissed on click#10344
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
RumBugen:fix/gameinfo-closed-10342

Conversation

@RumBugen
Copy link
Copy Markdown
Contributor

@RumBugen RumBugen commented Apr 2, 2026

Pull Request

Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.


Summary

Prevent the post-game info popup from dismissing itself on mouse down so its actions can actually be clicked. This fixes the case where the popup can handle input.

Motivation & Context

The popup shown after closing a game is meant to be interactive, but it was being queued with the toast area's default click-to-dismiss behavior. The default value for clickToDismiss has changed I guess, but I haven't spent much time analysing it. I only saw the issue and thought it must be something easy with the panel -.-

Fixes: #10342

Implementation Details

I think it's self-explanatory.

Screenshots / Videos (if applicable)

-/-

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

@solwllms solwllms added the triaged triaged pull-requests are replicated on the internal sbox repo label Apr 7, 2026
@sboxbot sboxbot added the accepted this pull request was accepted, hurrah! label Apr 7, 2026
@sboxbot
Copy link
Copy Markdown
Contributor

sboxbot commented Apr 7, 2026

This PR has been merged upstream.

@sboxbot sboxbot closed this Apr 7, 2026
@RumBugen RumBugen deleted the fix/gameinfo-closed-10342 branch April 16, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted this pull request was accepted, hurrah! triaged triaged pull-requests are replicated on the internal sbox repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The game info popup (after closing the game) cannot be clicked because it disappears

3 participants