Prevent package closed toast from being dismissed on click#10344
Closed
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
Closed
Prevent package closed toast from being dismissed on click#10344RumBugen wants to merge 1 commit intoFacepunch:masterfrom
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Contributor
|
This PR has been merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
Prevent the post-game info popup from dismissing itself on mouse down so its actions can actually be clicked. This fixes the case where the popup can handle input.
Motivation & Context
The popup shown after closing a game is meant to be interactive, but it was being queued with the toast area's default click-to-dismiss behavior. The default value for clickToDismiss has changed I guess, but I haven't spent much time analysing it. I only saw the issue and thought it must be something easy with the panel -.-
Fixes: #10342
Implementation Details
I think it's self-explanatory.
Screenshots / Videos (if applicable)
-/-
Checklist