Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
This PR fixes the video settings menu so the "Framerate Limit (game)" value is loaded from the saved render settings and written back when applying changes. This resolves a bug where the slider always reverted to 0 after reopening the settings.
Motivation & Context
The setting was exposed in the UI, but it was never actually connected to the persisted render setting. The menu code still had commented-out TODO lines referring to a non existent property, so the slider defaulted to 0 on reopen and user changes were never saved. I ran git blame and found the commit 38b5f79, which commented it out. It was probably forgotten to implement before the commit was made.
Fixes: #10361
Implementation Details
Replaced the commented out FrameRateLimit references in VideoSettings.razor with the actual persisted render setting.
If I missed anything, let me know :9
Screenshots / Videos (if applicable)
-/-
Checklist