Skip to content

Fix framerate limit not saving#10362

Open
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
RumBugen:fix/framerate-saving-10361
Open

Fix framerate limit not saving#10362
RumBugen wants to merge 1 commit intoFacepunch:masterfrom
RumBugen:fix/framerate-saving-10361

Conversation

@RumBugen
Copy link
Copy Markdown
Contributor

@RumBugen RumBugen commented Apr 4, 2026

Pull Request

Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.


Summary

This PR fixes the video settings menu so the "Framerate Limit (game)" value is loaded from the saved render settings and written back when applying changes. This resolves a bug where the slider always reverted to 0 after reopening the settings.

Motivation & Context

The setting was exposed in the UI, but it was never actually connected to the persisted render setting. The menu code still had commented-out TODO lines referring to a non existent property, so the slider defaulted to 0 on reopen and user changes were never saved. I ran git blame and found the commit 38b5f79, which commented it out. It was probably forgotten to implement before the commit was made.

Fixes: #10361

Implementation Details

Replaced the commented out FrameRateLimit references in VideoSettings.razor with the actual persisted render setting.
If I missed anything, let me know :9

Screenshots / Videos (if applicable)

-/-

Checklist

  • Code follows existing style and conventions
  • No unnecessary formatting or unrelated changes
  • Public APIs are documented (if applicable)
  • Unit tests added where applicable and all passing
  • I’m okay with this PR being rejected or requested to change 🙂

@lolleko lolleko requested a review from xezno April 7, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Framerate limit not saving

2 participants