Recalculate bounds when text scope changes#10369
Open
Infiland wants to merge 2 commits intoFacepunch:masterfrom
Open
Recalculate bounds when text scope changes#10369Infiland wants to merge 2 commits intoFacepunch:masterfrom
Infiland wants to merge 2 commits intoFacepunch:masterfrom
Conversation
Fixes Facepunch#10300 When updating text-related properties, replace the previous pattern match with a validity check (_so.IsValid()), assign the updated TextScope to the scene object, and call CalculateBounds(). This affects TextColor, FontSize, FontWeight, FontName and Text so that the scene object's bounds are kept in sync after scope changes.
Contributor
|
Shouldn't need to calculate bounds on TextColor change, the rest are fine |
Contributor
Author
Done |
handsomematt
added
the
triaged
|
Could this also fix #10162 ? |
aylaylay
approved these changes
Apr 7, 2026
Contributor
Author
|
This PR only fixes bounds for 3D text scene objects, so it probably won't fix the UI scale clipping since that's a different code path. I can make a new PR for that fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a 3d text object in a scene causes a crash after a few seconds. The crash is related to bounds where they did not recalculate previously.
Motivation & Context
Fixes #10300
Implementation Details
When updating text-related properties, replace the previous pattern match with a validity check (_so.IsValid()), assign the updated TextScope to the scene object, and call CalculateBounds(). This affects TextColor, FontSize, FontWeight, FontName and Text so that the scene object's bounds are kept in sync after scope changes.
Screenshots / Videos (if applicable)
-/-
Checklist