Refactor LowPassProcessor and HighPassProcessor#10381
Open
Guilhem-Pech wants to merge 1 commit intoFacepunch:masterfrom
Open
Refactor LowPassProcessor and HighPassProcessor#10381Guilhem-Pech wants to merge 1 commit intoFacepunch:masterfrom
Guilhem-Pech wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Contributor
|
I knew something was off with them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
This PR refactors the
LowPassProcessorandHighPassProcessorcomponents to improve code readability and maintainability.Motivation & Context
Highpass and lowpass were not LowPass and HighPass so I implemented them.
Screenshots / Videos (if applicable)
Checklist