Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
This PR renames the editor/widget mouse wheel callback from OnWheel to OnMouseWheel so it is consistent with the rest of the mouse event API and easier to discover in IntelliSense. It also updates existing internal overrides to use the new name.
Motivation & Context
I have done this to address the discoverability problem described in the linked issue. Users looking for mouse-related widget callbacks naturally search for OnMouse, but OnWheel did not follow that pattern.
Fixes: #4623
Implementation Details
I renamed the wheel event from OnWheel to OnMouseWheel, while keeping OnWheel as an obsolete compatibility layer that is still invoked from OnMouseWheel, so that existing overrides do not break immediately. I also updated the current overrides to use the new name. This was done intentionally to allow existing code to migrate without breaking everything, while guiding new code towards the clearer API name. If there's anything wrong with this approach, let me know and I'll change it.
Screenshots / Videos (if applicable)
Checklist