Copy default action set to standalone VR projects.#10433
Open
Loafiat wants to merge 1 commit intoFacepunch:masterfrom
Open
Copy default action set to standalone VR projects.#10433Loafiat wants to merge 1 commit intoFacepunch:masterfrom
Loafiat wants to merge 1 commit intoFacepunch:masterfrom
Conversation
Author
|
Not sure why formatting failed, I checked through and it seems to be all good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for contributing to s&box ❤️
Please fill out the sections below to help us review your change efficiently.
Summary
Fixes issue where the default action set wouldn't be copied over to exported standalone projects.
Motivation & Context
Currently when exporting a standalone VR project in S&box the project fails to open in VR, giving the error: "Failed to attach ActionSet to Session". This PR fixes this by including the actionsets in the export if the project supports VR.
Implementation Details
I was debating converting CoreWhitelist to an IEnumerator or adding an empty string which would be set to the right path if your project is in VR mode, but ended up just using Linq to append the path to the array when GetCoreFiles is executed.
Screenshots / Videos (if applicable)
Checklist