Reliably dispose of ConsoleWidget when entering play mode#10442
Open
ElmarTalibzade wants to merge 2 commits intoFacepunch:masterfrom
Open
Reliably dispose of ConsoleWidget when entering play mode#10442ElmarTalibzade wants to merge 2 commits intoFacepunch:masterfrom
ConsoleWidget when entering play mode#10442ElmarTalibzade wants to merge 2 commits intoFacepunch:masterfrom
Conversation
ConsoleWidget would try clearing of a disposed …ConsoleWidget when entering play mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
If you had "Clear Console On Play" enabled, you'd get the below, public facing error:
But this is the actual error that's being tossed around:
I believe it's caused because ConsoleWidget wasn't being propely disposed of.
Motivation & Context
Fixes: #10440
Implementation Details
The fix was straightforward, I made sure that
ConsoleWidgetsingleton instance was being properly disposed whenOnDestroyedcallback is called.I snooped around and got inspired by how it was already done in the codebase - mainly in
MainAssetBrowser(source) andSceneNetworkSystem(source).I also spotted that
Sandbox.ActionGraphsusing directive was unused so I nuked it.Screenshots / Videos (if applicable)
This is the error message people would be seeing in master at the present.
Checklist