Make JsonConvertFactory public sealed#10507
Open
QuackCola wants to merge 1 commit intoFacepunch:masterfrom
Open
Make JsonConvertFactory public sealed#10507QuackCola wants to merge 1 commit intoFacepunch:masterfrom
QuackCola wants to merge 1 commit intoFacepunch:masterfrom
Conversation
QuackCola
force-pushed
the
make-JsonConvertFactory-publicsealed
branch
from
be16496 to
6df2e9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr simply makes the class
JsonConvertFactoryinUtility/Json/IJsonConvert.cspublic sealedMotivation & Context
This change is needed so
JsonConvertFactorycan be added to to your own JsonSerializerOptions. So that you can serialize and deserialize types such asVariantwhen not usingSandbox.Json.SerializeImplementation Details
Made the class
public sealedso that it can be used externally but not extended.Checklist