Whitelist System.Private.CoreLib/System.Threading.Tasks.TaskContinuationOptions#10522
Open
LeQuackers wants to merge 1 commit intoFacepunch:masterfrom
Open
Whitelist System.Private.CoreLib/System.Threading.Tasks.TaskContinuationOptions#10522LeQuackers wants to merge 1 commit intoFacepunch:masterfrom
System.Private.CoreLib/System.Threading.Tasks.TaskContinuationOptions#10522LeQuackers wants to merge 1 commit intoFacepunch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a quick PR to whitelist
TaskCreationOptions.RunContinuationsAsynchronously.In short,
TaskCompletionSourcecontinuations are executed synchronously unless theTaskCreationOptions.RunContinuationsAsynchronouslyoption is specified, which sucks.There was a dotnet TPL cookbook that mentioned it as a best practice, but I can't find it for the life of me, so here's a MSDN devblog instead (see "Conclusion" section at the bottom):
https://devblogs.microsoft.com/premier-developer/the-danger-of-taskcompletionsourcet-class/
Motivation & Context
The motivation and context were mentioned in the summary as well; allowing
TaskCompletionSourceto run asynchronously.Fixes: #10520
Implementation Details
The other
TaskCreationOptionsflags seem reasonable, butTaskCreationOptions.HideSchedulermight be problematic and I'd like another pair of eyes on it.Screenshots / Videos (if applicable)
Checklist