Screenshot Service Enhancements#112
Closed
PatrickJnr wants to merge 6 commits intoFacepunch:masterfrom
Closed
Conversation
…apture mode - Add multiple output formats: PNG, JPEG, WebP with quality settings - Add screenshot_clean and screenshot_highres_clean commands for UI-free capture - Add configurable MSAA for high-res screenshots (1-16x) - Add Steam screenshot library integration toggle - Add ScreenshotCapturedEventArgs and OnScreenshotCaptured event
…apture mode - Add multiple output formats: PNG, JPEG, WebP with quality settings - Add screenshot_clean and screenshot_highres_clean commands for UI-free capture - Add configurable MSAA for high-res screenshots (1-16x) - Add Steam screenshot library integration toggle - Add ScreenshotCapturedEventArgs and OnScreenshotCaptured event
1affd90 to
463046b
Compare
Member
|
Up to you @lolleko this is your stuff |
Contributor
|
Thanks for the PR, but I think those are too many options.
TL;DR you sold me on |
Member
|
It would have been nice if these weren't just commands at this point, but had a place in the editor somewhere |
Contributor
Author
I could remove the other commands and have it just |
…PatrickJnr/sbox-public into feature/screenshot-enhancements
Contributor
Author
|
I messed up with some stuff, I'm going to close this pr and create a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot Service Enhancements
This PR introduces new features to the screenshot system, enhancing format flexibility and adding UI-free capture modes.
New Commands
screenshot_cleanscreenshot_highres_clean <w> <h>New ConVars
screenshot_formatPNGPNG,JPEG, orWebPscreenshot_quality90screenshot_cursorfalsescreenshot_steamtruescreenshot_highres_msaa16New Events
ScreenshotService.OnScreenshotCaptured- Static event fired after any screenshot is savedFilePath,Width,Height, Format, FileSize,IsHighResUsage Examples
Clean screenshots (no UI):
screenshot_cleanscreenshot_highres_clean 3840 2160WebP for smaller files:
screenshot_format WebPscreenshot_quality 95screenshotCustom MSAA for high-res:
screenshot_highres_msaa 8screenshot_highres 6880 2880Files Changed
screenshot_cleanandscreenshot_highres_cleancommandsSuppressUIflag for clean screenshotsSuppressUIcheck inOnCameraRenderUIScreenshots
With and without UI
WebP 90% Quality vs 1% Quality
MSAA 1 vs 16